On Sat, Sep 17, 2016 at 04:49:11AM +0000, Tang, CQ wrote:
> Can we extend this aerdriver to support AER from a root complex
> integrated endpoint? Root complex event collector has the same job as root
> port in this case.
Seems like a reasonable idea.
> It looks that both port driver and aer driver check
> PCI_EXP_TYPE_ROOT_PORT/PCI_EXP_TYPE_UPSTREAM/PCI_EXP_TYPE_DOWNSTREAM only.
> portdrv_pci.c:127, aerdrv.c:86
> Is it just a simple addition of PCI_EXP_TYPE_RC_EC to above two places?
> Is there any difference to recover a root complex integrated endpoint?
> (compared with devices connected to root port).
It may well be that the extension would be as simple as you suggest.
If you want to test and post a patch to that effect, I'll review it
> > -----Original Message-----
> > From: linux-pci-ow...@vger.kernel.org [mailto:linux-pci-
> > ow...@vger.kernel.org] On Behalf Of Bjorn Helgaas
> > Sent: Wednesday, September 14, 2016 1:30 PM
> > To: Bjorn Helgaas <bhelg...@google.com>
> > Cc: linux-...@vger.kernel.org; Lance Ortiz <lance.or...@hpe.com>; Betty Dall
> > <betty.d...@hpe.com>; Hidetoshi Seto <seto.hideto...@jp.fujitsu.com>;
> > Chen Gong <gong.c...@linux.intel.com>; keithbuschkeith.bu...@intel.com;
> > Rafael J. Wysocki <r...@rjwysocki.net>; firstname.lastname@example.org; Shuah
> > Khan <shua...@osg.samsung.com>; Huang, Ying <ying.hu...@intel.com>;
> > Vijay Mohan Pandarathil <vijaymohan.pandarat...@hpe.com>; Derrick,
> > Jonathan <jonathan.derr...@intel.com>
> > Subject: Re: [PATCH 0/2] PCI/AER: Remove module parameters
> > On Tue, Sep 06, 2016 at 05:19:22PM -0500, Bjorn Helgaas wrote:
> > > I'd like to remove the aerdriver.nosourceid and aerdriver.forceload
> > > kernel parameters. They seem like basically debugging things that are
> > > not really supportable upstream.
> > >
> > > "nosourceid" may have some legitimate uses, but I'd rather it were
> > > done via quirks with the flag Jon Derrick recently added so it happens
> > > automatically, without users having to specify the parameter.
> > >
> > > I don't *know* of any actual users of either of these, but obviously
> > > that doesn't mean there are none. Comments welcome.
> > >
> > > ---
> > >
> > > Bjorn Helgaas (2):
> > > PCI/AER: Remove aerdriver.nosourceid kernel parameter
> > > PCI/AER: Remove aerdriver.forceload kernel parameter
> > >
> > >
> > > Documentation/PCI/pcieaer-howto.txt | 26 +++++++++-----------------
> > > drivers/pci/pcie/aer/aerdrv.c | 7 +------
> > > drivers/pci/pcie/aer/aerdrv.h | 8 --------
> > > drivers/pci/pcie/aer/aerdrv_core.c | 31
> > > ++++---------------------------
> > > 4 files changed, 14 insertions(+), 58 deletions(-)
> > I'm going to go out on a limb a little bit and apply these to pci/aer for
> > v4.9.
> > Please let me know if you trip over any issues.
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-pci" in the
> > body of a message to majord...@vger.kernel.org More majordomo info at
> > http://vger.kernel.org/majordomo-info.html