christophe leroy <christophe.le...@c-s.fr> writes:
>>
>>
>>> for (psize = 0; psize < MMU_PAGE_COUNT; ++psize) {
>>> unsigned shift;
>>> unsigned pdshift;
>>> @@ -860,16 +807,31 @@ static int __init hugetlbpage_init(void)
>>> * if we have pdshift and shift value same, we don't
>>> * use pgt cache for hugepd.
>>> */
>>> - if (pdshift != shift) {
>>> + if (pdshift > shift) {
>>> pgtable_cache_add(pdshift - shift, NULL);
>>> if (!PGT_CACHE(pdshift - shift))
>>> panic("hugetlbpage_init(): could not create "
>>> "pgtable cache for %d bit pagesize\n",
>>> shift);
>>> + } else if (!hugepte_cache) {
>>> + /*
>>> + * Create a kmem cache for hugeptes. The bottom bits in
>>> + * the pte have size information encoded in them, so
>>> + * align them to allow this
>>> + */
>>> + hugepte_cache = kmem_cache_create("hugepte-cache",
>>> + sizeof(pte_t),
>>> + HUGEPD_SHIFT_MASK + 1,
>>> + 0, NULL);
>>> + if (hugepte_cache == NULL)
>>> + panic("%s: Unable to create kmem cache "
>>> + "for hugeptes\n", __func__);
>>> +
>>
>>
>> We don't need hugepte_cache for book3s 64K. I guess we will endup
>> creating one here ?
>
> Should not, because on book3s 64k, we will have pdshift > shift
> won't we ?
>
on 64k book3s, we have pdshift == shift and we don't need to create
hugepd cache on book3s 64k.
-aneesh
