On Mon, Sep 19, 2016 at 12:46 PM, Sebastian Reichel <s...@kernel.org> wrote: > Hi, > > On Fri, Sep 16, 2016 at 08:42:54PM -0700, Matt Ranostay wrote: >> Allow the poll_interval to be runtime configurable via an sysfs >> entry. This is needed for udev control of the poll interval. >> >> Signed-off-by: Matt Ranostay <email@example.com> >> --- >> drivers/power/supply/bq27xxx_battery.c | 48 >> +++++++++++++++++++++++++++++++++- >> 1 file changed, 47 insertions(+), 1 deletion(-) > > New sysfs attributes should be documented in Documentation/ABI.
Yeah I should know better :) > > Also I'm not too keen to add this, as there is already the sysfs > entry for the module parameter. I don't see any reason why udev > should not be able to change that value, so fix udev instead of > duplicating functionality in the kernel. Yeah duplication is bad. We are wondering if having a POWER_SUPPLY_PROP_UPDATE_INTERVAL would be an more acceptable solution. Of course this would need to be made generic and not a per driver solution as it is now. Thanks, Matt > > -- Sebastian