Hi Boris Thanks for your review.
On Tue, Sep 20, 2016 at 1:21 PM, Boris Brezillon <[email protected]> wrote: >> int sr, fsr; >> - sr = spi_nor_sr_ready(nor); >> + >> + sr = nor->flags & SNOR_F_READY_XSR_RDY ? s3an_sr_ready(nor) : >> + spi_nor_sr_ready(nor); > > Nit: I find > > if (nor->flags & SNOR_F_READY_XSR_RDY) > sr = s3an_sr_ready(nor); > else > sr = spi_nor_sr_ready(nor); Fixed in v6 >> +static loff_t spi_nor_s3an_addr_convert(struct spi_nor *nor, unsigned int >> addr) >> +{ >> + unsigned int offset; >> + >> + offset = (nor->page_size == 264) ? (addr % 264) : (addr % 528); > > Why not just > > offset = addr % nor->page_size; > Because kbuild test robot does not like it ;) make.cross ARCH=blackfin All errors (new ones prefixed by >>): drivers/built-in.o: In function `spi_nor_write': >> drivers/mtd/spi-nor/spi-nor.c:1050: undefined reference to `__moddi3' vim +1050 drivers/mtd/spi-nor/spi-nor.c Thanks! -- Ricardo Ribalda
