On 2016-09-07 01:43, Meng Yi wrote:
> Hi Stefan,
> 
> I had tested the patches on LS1021A-TWR board using drmlib.
> 
> Like set three overlays:
> root@ls1021atwr:~# ./modetest -P 39:900x100+10+10@RG24 -P
> 39:200x200+300+0@RG24 -P 39:200x200+400+300@RG24
> 
> How did you test the overlays and cursor layer, I mean I see you using
> x-window like thing in the  video.

I did use X with the modesetting driver. You just need to choose
modesetting in your xorg.conf, and it should make use of the cursor
layer automatically.

>> This patchset adds overlay and cursor plane support. It also fixes some 
>> issues
>> uncovered during implementation of this.
>>
>> However, the plane updates currently causes the display to flicker for 
>> unknown
>> reasons. As far as I can tell, the CRTC atomic_flush should trigger the 
>> update
>> correctly via READREG, which according to
>> documentation:
>> The READREG bit causes a single transfer to begin at the next frame blanking
>> period. This bit is cleared when the transfer is complete.
>>
>> I made a video how that looks:
>> https://cloud.agner.ch/index.php/s/Yfqa2u7UBEWUT8N

It would be interesting whether you see that on LS1021a too.

--
Stefan

>>
>> Any ideas?
>>
>> Stefan Agner (4):
>>   drm/fsl-dcu: support overlay and cursor planes
>>   drm/fsl-dcu: respect pos/size register sizes
>>   drm/fsl-dcu: update all registers on flush
>>   drm/fsl-dcu: do not update when modifying irq registers
>>
>>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c  | 50
>> ++++++++++++++++++++++++-----
>>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c   |  4 ---
>>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h   |  8 ++---
>>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 42 +++++++++++-------------
>> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.h |  3 +-
>>  5 files changed, 67 insertions(+), 40 deletions(-)
>>
>> --
>> 2.9.3

Reply via email to