On Wed, Sep 21, 2016 at 3:25 PM, Laura Abbott <labb...@redhat.com> wrote:
> virt_addr_valid is supposed to return true if and only if virt_to_page
> returns a valid page structure. The current macro does math on whatever
> address is given and passes that to pfn_valid to verify. vmalloc and
> module addresses can happen to generate a pfn that 'happens' to be
> valid. Fix this by only performing the pfn_valid check on addresses that
> have the potential to be valid.
> Acked-by: Mark Rutland <mark.rutl...@arm.com>
> Signed-off-by: Laura Abbott <labb...@redhat.com>
> ---
> v2: Properly parenthesize macro arguments. Re-factor to common macro.
> Also in case it wasn't clear, there's no need to try and squeeze this
> into 4.8. Hardened usercopy should have all the checks, this is just for
> full correctness.

After this lands for 4.9, I should likely drop the checks that are in
hardened usercopy? That'll speed things up ever so slightly, and will
let us catch other architectures that have a weird


Kees Cook
Nexus Security

Reply via email to