On 22 September 2016 at 18:58, Mark Brown <broo...@kernel.org> wrote:
> On Thu, Sep 22, 2016 at 06:53:12PM +0800, Baolin Wang wrote:
>> From: Badhri Jagan Sridharan <bad...@google.com>
>> Some USB managament on userspace (like Android system) rely on the uevents
>> generated by the composition driver to generate user notifications. Thus this
>> patch adds uevents to be generated whenever USB changes its state: connected,
>> disconnected, configured.
>> The original code was created by Badhri Jagan Sridharan, and I did some
>> optimization.
>> CC: Badhri Jagan Sridharan <bad...@google.com>
>> Signed-off-by: Baolin Wang <baolin.w...@linaro.org>
> If you're sending a patch someone else wrote you need their
> Signed-off-by - if they didn't provide one you need to talk to them
> about that and get it.

Ah, I missed that. I will add it if there are no objection from Badhr.i

>> +     boolean "Uevent notification of Gadget state"
>> +     depends on USB_CONFIGFS
>> +     help
>> +       Enable uevent notifications to userspace when the gadget
>> +       state changes. The gadget can be in any of the following
> Why not just generate the events unconditionally?

If userspace doesn't need notification, then we can save some time to
do the enumeration without the uevent things.

Best Regards

Reply via email to