On 09/22/16 13:45, Mugunthan V N wrote:
>>> +   if (!dma->chan)
>>> +           return -ENODEV;
>>> +
>>> +   /* RX buffer */
>>> +   dma->buf = dma_alloc_coherent(dma->chan->device->dev, DMA_BUFFER_SIZE,
>>> +                                 &dma->addr, GFP_KERNEL);
>>> +   if (!dma->buf)
>>> +           goto err;
>>> +
>>> +   dev_dbg_ratelimited(adc_dev->mfd_tscadc->dev, "got dma channel\n");
>>
>> Do we need _ratelimited? AFAICS, this print is called only once.
> 
> True, will change to dev_dbg.

It would be better to remove it. It gives no useful debuggin information apart
from the fact that the driver did not failed to probe.

-- 
P├ęter

Reply via email to