On Thu, Sep 22 2016, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wag...@bmw-carit.de>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> waiter context                          waker context
>   reinit_completion()
>   usb_esp_queue()
>   wait_for_completion_interruptible()
>
>                                       ffs_ep0_complete()
>                                         complete()
>
> Signed-off-by: Daniel Wagner <daniel.wag...@bmw-carit.de>
> Cc: Felipe Balbi <ba...@kernel.org>
> Cc: Michal Nazarewicz <min...@mina86.com>

Acked-by: Michal Nazarewicz <min...@mina86.com>

> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: linux-...@vger.kernel.org
> ---
>  drivers/usb/gadget/function/f_fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_fs.c 
> b/drivers/usb/gadget/function/f_fs.c
> index 5c8429f..0c29039 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -211,7 +211,7 @@ static void ffs_ep0_complete(struct usb_ep *ep, struct 
> usb_request *req)
>  {
>       struct ffs_data *ffs = req->context;
>  
> -     complete_all(&ffs->ep0req_completion);
> +     complete(&ffs->ep0req_completion);
>  }
>  
>  static int __ffs_ep0_queue_wait(struct ffs_data *ffs, char *data, size_t len)
> -- 
> 2.7.4

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»

Reply via email to