On Mon, 26 Sep 2016 10:27:41 +0300 Adrian Hunter <[email protected]> wrote:
> On 24/09/16 03:15, Masami Hiramatsu wrote: > > On Fri, 23 Sep 2016 17:38:40 +0300 > > Adrian Hunter <[email protected]> wrote: > > > >> Two SDT debug messages can occur for every DSO which is too noisy. > >> Consequently, increase debug level of SDT messages. > > > > OK, but why "4" would you choose? > > 2 is used for displaying the event attributes, so it needs to be 3 or 4. I > chose 4 because of the large number of messages and that the same messages > appear every time. Hmm, yes, but this message is also useful for checking user to stack on retrieving SDT or not. I think it is a time to introduce debug printk like feature to perf, because we need to control on/off depending on which subcommand we are debugging. Anyway, at this point it is OK for me. Acked-by: Masami Hiramatsu <[email protected]> > > > > > Thanks, > > > >> > >> Signed-off-by: Adrian Hunter <[email protected]> > >> --- > >> tools/perf/util/build-id.c | 4 ++-- > >> tools/perf/util/probe-file.c | 2 +- > >> 2 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c > >> index 5651f3c12f93..e528c40739cc 100644 > >> --- a/tools/perf/util/build-id.c > >> +++ b/tools/perf/util/build-id.c > >> @@ -620,7 +620,7 @@ static int build_id_cache__add_sdt_cache(const char > >> *sbuild_id, > >> > >> ret = probe_cache__scan_sdt(cache, realname); > >> if (ret >= 0) { > >> - pr_debug("Found %d SDTs in %s\n", ret, realname); > >> + pr_debug4("Found %d SDTs in %s\n", ret, realname); > >> if (probe_cache__commit(cache) < 0) > >> ret = -1; > >> } > >> @@ -691,7 +691,7 @@ int build_id_cache__add_s(const char *sbuild_id, const > >> char *name, > >> > >> /* Update SDT cache : error is just warned */ > >> if (build_id_cache__add_sdt_cache(sbuild_id, realname) < 0) > >> - pr_debug("Failed to update/scan SDT cache for %s\n", realname); > >> + pr_debug4("Failed to update/scan SDT cache for %s\n", realname); > >> > >> out_free: > >> if (!is_kallsyms) > >> diff --git a/tools/perf/util/probe-file.c b/tools/perf/util/probe-file.c > >> index 6f931e442f14..436b64731f65 100644 > >> --- a/tools/perf/util/probe-file.c > >> +++ b/tools/perf/util/probe-file.c > >> @@ -699,7 +699,7 @@ int probe_cache__scan_sdt(struct probe_cache *pcache, > >> const char *pathname) > >> INIT_LIST_HEAD(&sdtlist); > >> ret = get_sdt_note_list(&sdtlist, pathname); > >> if (ret < 0) { > >> - pr_debug("Failed to get sdt note: %d\n", ret); > >> + pr_debug4("Failed to get sdt note: %d\n", ret); > >> return ret; > >> } > >> list_for_each_entry(note, &sdtlist, note_list) { > >> -- > >> 1.9.1 > >> > > > > > -- Masami Hiramatsu <[email protected]>
