----- KRYPTIVA PACKAGED MESSAGE ----- PACKAGING TYPE: SIGNED
Mathieu Desnoyers wrote: > The problem with your proposal, I guess, is that people will have to add a supplementary parameter to the macro. > > It is not uncommon to have two slightly versions of macros/functions in the kernel (preempt_enable()/preempt_enable_no_resched(), or macros starting with underscores). Normally, the underscore states that the macro does not do the proper locking itself (this is not our case). Therefore, I would suggest using a name that suggests against what the macro is protected. For instance, a marker > pointing to the generic version is only needed to protect against the debug trap handler and should only be used on x86 and x86_64. I can see your point, to a degree. The difference here is that the variants you mention are actually macros that do something, they aren't stubs for code. IOW, you actually know what's happening underneath a foo() vs. _foo() by its name only. Maybe this applies the same to markers, I don't know. But maybe we want to make it easy for those looking at markers that there's a master kill switch somewhere that all markers go through and through which they can all be disabled very simply (say by using a "#if 0"). While different names *may* be doing that, a same name *does* that. But I don't feel too strongly either way, it's really up to those who maintaining the code to say. Karim ----- KRYPTIVA SIGNED MESSAGE ----- This email claims to have been packaged by Kryptiva. To process this email and authenticate its origin, get the free plugin from: http://www.kryptiva.com/downloads ----- KRYPTIVA SIGNATURE START ----- AvWVqAAAAAIAAAABAAAAAAAATiACAQAAAAC3AQAIAAAAAgAAAAECABTXxT4xHdR4/1uU1hL2 +TaPrqNB0wMAFNa8GHXZWJH5Dz+D76vfh6JhvWLvBAAUpuIZcCAkCC+ldyaBuoAWxK50HiQF ABRI38gc/foDHQsS6X3W0VP4xTukBwYAFB0lithGcxNZYBHaLDONjp6eo/LoBwAUpXC6F2jf nElq3fnZQpGW97Fk/2QRABgAAAAAAABOIEXcvqAADJ5wAAAAAAAAAB4TAAQAAAAAAAAAggP/ RQ/W0H9H9bhrZyC67an//DbWC4D38PgLoeMG6Tjvx7jWTpEh79DeQ/+sbb9aYZvbwYwtaVaJ VuPEiRnPZX0mqnOFm+GDzE9jB6202lR0Nzczh1WCifbrrXI7CSEjOwI3ve0jcCoGxTEzZRYj LGxuubV8Hh5HU12zi3Mxgdz031Y= ----- KRYPTIVA SIGNATURE END ----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/