On Thu, Oct 06, 2016 at 11:29:20AM +0200, Richard Weinberger wrote: > On Thu, Oct 6, 2016 at 11:22 AM, SF Markus Elfring > <elfr...@users.sourceforge.net> wrote: > > From: Markus Elfring <elfr...@users.sourceforge.net> > > Date: Tue, 4 Oct 2016 21:46:18 +0200 > > > > Replace the specification of a data structure by a pointer dereference > > as the parameter for the operator "sizeof" to make the corresponding size > > determination a bit safer. > > Isn't this pure matter of taste? > Some developers prefer sizeof(*ptr) because it is easier to type, other > developers prefer sizeof(struct foo) because you can determine the type > at first sight and makes review more easy.
sizeof(*ptr) is more future proof and normally more obvious and easier to review. That said, I've tried to tell Markus to only send bugfix patches because these are a waste of time and regularly introduce bugs. regards, dan carpenter
