On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote: > Rather you it would be better not to use cmdReady/goIdle at all if > kernel is not compiled with CONFIG_PM.
It would be best practice to ensure the tpm is powered up no matter how the kernel is compiled.. The firmware may have left it in idle or something FWIW, I broadly agree there is no need to put the device into idle on the error paths. It probably wasn't idle when the driver attached to it. Jason
