On Sun, Oct 9, 2016 at 8:56 PM, Christoph Hellwig <[email protected]> wrote: > Hi Andy, > > two comment on your ぱatch to add MSI support to the above driver. > > First pci_alloc_irq_vectors gained a mandatory flags argument, so > for MSI suport you now need to pass PCI_IRQ_MSI in flags for the > code to work.
I will check this. Thanks for pointing to it. > > Second please make sure to always pair pci_alloc_irq_vectors > with pci_free_irq_vectors on the remove path. For my opinion it should be done in PCI code since I'm using manageable resources. It's already done for all PCI API usually used at ->probe(). -- With Best Regards, Andy Shevchenko
