On Fri, Oct 7, 2016 at 10:28 PM, Joel Fernandes <joe...@google.com> wrote:
> PMSG now uses ramoops_pstore_write_buf_user instead of
> ramoops_pstore_write_buf
> Remove the case where we check PSTORE_TYPE_PMSG case.
Ah yeah, good point. Can you actually improve this to add a
ratelimited WARN() to both _write_buf and write_buf_user when an
unhandled type is encountered?
-Kees
>
> Signed-off-by: Joel Fernandes <joe...@google.com>
> ---
> fs/pstore/ram.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 751197d..519404c 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -287,11 +287,6 @@ static int notrace ramoops_pstore_write_buf(enum
> pstore_type_id type,
> return -ENOMEM;
> persistent_ram_write(cxt->fprz, buf, size, 1);
> return 0;
> - } else if (type == PSTORE_TYPE_PMSG) {
> - if (!cxt->mprz)
> - return -ENOMEM;
> - persistent_ram_write(cxt->mprz, buf, size, 1);
> - return 0;
> }
>
> if (type != PSTORE_TYPE_DMESG)
> --
> 2.7.4
>
--
Kees Cook
Nexus Security
