From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Wed, 12 Oct 2016 10:20:02 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/media/platform/davinci/vpfe_capture.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/davinci/vpfe_capture.c 
b/drivers/media/platform/davinci/vpfe_capture.c
index 6efb2f1..5c1b8cf 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -1940,8 +1940,9 @@ static int vpfe_probe(struct platform_device *pdev)
        video_set_drvdata(&vpfe_dev->video_dev, vpfe_dev);
        i2c_adap = i2c_get_adapter(vpfe_cfg->i2c_adapter_id);
        num_subdevs = vpfe_cfg->num_subdevs;
-       vpfe_dev->sd = kmalloc(sizeof(struct v4l2_subdev *) * num_subdevs,
-                               GFP_KERNEL);
+       vpfe_dev->sd = kmalloc_array(num_subdevs,
+                                    sizeof(*vpfe_dev->sd),
+                                    GFP_KERNEL);
        if (NULL == vpfe_dev->sd) {
                v4l2_err(&vpfe_dev->v4l2_dev,
                        "unable to allocate memory for subdevice pointers\n");
-- 
2.10.1

Reply via email to