From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Thu, 13 Oct 2016 10:25:57 +0200

Move the assignment for the data structure member "transmitting"
and the local variable "curlencheck" behind the source code
for memory allocations by this function.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/media/rc/redrat3.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
index d89958b..f5a6850 100644
--- a/drivers/media/rc/redrat3.c
+++ b/drivers/media/rc/redrat3.c
@@ -727,7 +727,7 @@ static int redrat3_transmit_ir(struct rc_dev *rcdev, 
unsigned *txbuf,
        int ret, ret_len;
        int lencheck, cur_sample_len, pipe;
        int *sample_lens = NULL;
-       u8 curlencheck = 0;
+       u8 curlencheck;
        unsigned i, sendbuf_len;
 
        if (rr3->transmitting) {
@@ -738,9 +738,6 @@ static int redrat3_transmit_ir(struct rc_dev *rcdev, 
unsigned *txbuf,
        if (count > RR3_MAX_SIG_SIZE - RR3_TX_TRAILER_LEN)
                return -EINVAL;
 
-       /* rr3 will disable rc detector on transmit */
-       rr3->transmitting = true;
-
        sample_lens = kcalloc(RR3_DRIVER_MAXLENS,
                              sizeof(*sample_lens),
                              GFP_KERNEL);
@@ -755,6 +752,9 @@ static int redrat3_transmit_ir(struct rc_dev *rcdev, 
unsigned *txbuf,
                goto out;
        }
 
+       /* rr3 will disable rc detector on transmit */
+       rr3->transmitting = true;
+       curlencheck = 0;
        for (i = 0; i < count; i++) {
                cur_sample_len = redrat3_us_to_len(txbuf[i]);
                if (cur_sample_len > 0xffff) {
-- 
2.10.1

Reply via email to