Hi Matthias, Thanks for your review. On Thu, 2016-10-13 at 15:00 +0200, Matthias Brugger wrote: > > On 10/13/2016 07:06 AM, Youlin Pei wrote: > > This commit adds the device tree binding document for > > the mediatek cirq. > > > > Signed-off-by: Youlin Pei <youlin....@mediatek.com> > > > > --- > > base on v4.8-rc1 > > --- > > .../interrupt-controller/mediatek,cirq.txt | 30 > > ++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/interrupt-controller/mediatek,cirq.txt > > > > diff --git > > a/Documentation/devicetree/bindings/interrupt-controller/mediatek,cirq.txt > > b/Documentation/devicetree/bindings/interrupt-controller/mediatek,cirq.txt > > new file mode 100644 > > index 0000000..ad16953 > > --- /dev/null > > +++ > > b/Documentation/devicetree/bindings/interrupt-controller/mediatek,cirq.txt > > @@ -0,0 +1,30 @@ > > +* Mediatek 27xx cirq > > + > > +In Mediatek SOCs, the CIRQ is a low power interrupt controller designed to > > +works outside MCUSYS which comprises with Cortex-Ax cores,CCI and GIC. > > +The external interrupts (outside MCUSYS) will feed through CIRQ and connect > > +to GIC in MCUSYS. When CIRQ is enabled, it will record the edge-sensitive > > +interrupts and generated a pulse signal to parent interrupt controller when > > +flush command is executed. With CIRQ, MCUSYS can be completely turned off > > +to improve the system power consumption without losing interrupts. > > + > > +Required properties: > > +- compatible: should be: "mediatek,mt2701-cirq". > > The cirq is present in several SoCs. I suppose it is the same core in > all of them. So we can name it mediatek,mtk-cirq and add a > mediatek,mtXXXX-cirq for every SoC, just in case we will need it.
Okay, will change it in next version. Thanks. > > Thanks, > Matthias Thanks. Youlin