Commit-ID: c0ca8df717061ae3d2ea624024033103c64210ae
Gitweb: http://git.kernel.org/tip/c0ca8df717061ae3d2ea624024033103c64210ae
Author: Noam Camus <noa...@mellanox.com>
AuthorDate: Thu, 13 Oct 2016 16:15:32 +0300
Committer: Thomas Gleixner <t...@linutronix.de>
CommitDate: Fri, 14 Oct 2016 14:26:54 +0200
irqchip/eznps: Acknowledge NPS_IPI before calling the handler
IPI_IRQ (also TIMER0_IRQ) should be acked before the action->handler is called
in handle_percpu_devid_irq.
The IPI irq is edge sensitive and we might miss an IPI interrupt if it is
triggered again while the handler runs.
Fixes: 44df427c894a ("irqchip: add nps Internal and external irqchips")
Signed-off-by: Noam Camus <noa...@mellanox.com>
Cc: marc.zyng...@arm.com
Cc: ja...@lakedaemon.net
Cc: sta...@vger.kernel.org
Link:
http://lkml.kernel.org/r/1476364532-12634-1-git-send-email-noa...@mellanox.com
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
---
drivers/irqchip/irq-eznps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-eznps.c b/drivers/irqchip/irq-eznps.c
index efbf0e4..ebc2b0b 100644
--- a/drivers/irqchip/irq-eznps.c
+++ b/drivers/irqchip/irq-eznps.c
@@ -85,7 +85,7 @@ static void nps400_irq_eoi_global(struct irq_data *irqd)
nps_ack_gic();
}
-static void nps400_irq_eoi(struct irq_data *irqd)
+static void nps400_irq_ack(struct irq_data *irqd)
{
unsigned int __maybe_unused irq = irqd_to_hwirq(irqd);
@@ -103,7 +103,7 @@ static struct irq_chip nps400_irq_chip_percpu = {
.name = "NPS400 IC",
.irq_mask = nps400_irq_mask,
.irq_unmask = nps400_irq_unmask,
- .irq_eoi = nps400_irq_eoi,
+ .irq_ack = nps400_irq_ack,
};
static int nps400_irq_map(struct irq_domain *d, unsigned int virq,
