From: Jeff Mahoney <je...@suse.com>

3.12-stable review patch.  If anyone has any objections, please let me know.

===============

Prior to v3.17, XFS used positive error codes internally.  Commit
af8d971602b9583e5e8400e637e2a48c7480bc64 (xfs: inode recovery
readahead can race with inode buffer creation), upstream commit
b79f4a1c68bb99152d0785ee4ea3ab4396cdacc6 backported from later
releases need the error code signs reversed.  Negative error codes
will cause assertion failures (BUG_ON on kernels with assertions
enabled.

Signed-off-by: Jeff Mahoney <je...@suse.com>
Cc: Dave Chinner <dchin...@redhat.com>
Cc: Brian Foster <bfos...@redhat.com>
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
---
 fs/xfs/xfs_inode_buf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_inode_buf.c b/fs/xfs/xfs_inode_buf.c
index 4b1447b3a9e4..03d237a0f58b 100644
--- a/fs/xfs/xfs_inode_buf.c
+++ b/fs/xfs/xfs_inode_buf.c
@@ -99,7 +99,7 @@ xfs_inode_buf_verify(
                                                XFS_RANDOM_ITOBP_INOTOBP))) {
                        if (readahead) {
                                bp->b_flags &= ~XBF_DONE;
-                               xfs_buf_ioerror(bp, -EIO);
+                               xfs_buf_ioerror(bp, EIO);
                                return;
                        }
 
-- 
2.10.1

Reply via email to