From: Arnd Bergmann <>

3.12-stable review patch.  If anyone has any objections, please let me know.


commit 8e0cc8c326d99e41468c96fea9785ab78883a281 upstream.

gcc points out code that is not indented the way it is

net/caif/cfpkt_skbuff.c: In function 'cfpkt_setlen':
net/caif/cfpkt_skbuff.c:289:4: error: statement is indented as if it were 
guarded by... [-Werror=misleading-indentation]
    return cfpkt_getlen(pkt);
net/caif/cfpkt_skbuff.c:286:3: note: ...this 'else' clause, but it is not

It is clear from the context that not returning here would be
a bug, as we'd end up passing a negative length into a function
that takes a u16 length, so it is not missing curly braces
here, and I'm assuming that the indentation is the only part
that's wrong about it.

Signed-off-by: Arnd Bergmann <>
Signed-off-by: David S. Miller <>
Signed-off-by: Jiri Slaby <>
 net/caif/cfpkt_skbuff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c
index 6493351f39c6..715251b72d7f 100644
--- a/net/caif/cfpkt_skbuff.c
+++ b/net/caif/cfpkt_skbuff.c
@@ -296,7 +296,7 @@ int cfpkt_setlen(struct cfpkt *pkt, u16 len)
                        skb_trim(skb, len);
-                       return cfpkt_getlen(pkt);
+               return cfpkt_getlen(pkt);
        /* Need to expand SKB */

Reply via email to