From: Wei Yongjun <weiyongj...@huawei.com>

In case of error, the function kthread_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index e11c0e0..ccd1735 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -2781,7 +2781,7 @@ void vchiq_platform_conn_state_changed(VCHIQ_STATE_T 
*state,
                                &vchiq_keepalive_thread_func,
                                (void *)state,
                                threadname);
-                       if (arm_state->ka_thread == NULL) {
+                       if (IS_ERR(arm_state->ka_thread)) {
                                vchiq_log_error(vchiq_susp_log_level,
                                        "vchiq: FATAL: couldn't create thread 
%s",
                                        threadname);

Reply via email to