mmc_regulator_get_supply might silently fail if the regulators are not
found, which is the right thing to do since both these regulators are

However, the drivers then have no way to know whether or not they should
proceed and call mmc_regulator_set_ocr. And since this function doesn't
check for the validity of the regulator pointer, it leads to a null pointer
dereference. Add such a check to make sure everything works fine.

Signed-off-by: Maxime Ripard <>
 drivers/mmc/core/core.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 2553d903a82b..1d3ea5e1aa37 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -1474,6 +1474,12 @@ int mmc_regulator_set_ocr(struct mmc_host *mmc,
        int                     result = 0;
        int                     min_uV, max_uV;
+       if (!supply)
+               return -EINVAL;
+       if (IS_ERR(supply))
+               return PTR_ERR(supply);
        if (vdd_bit) {
                mmc_ocrbitnum_to_vdd(vdd_bit, &min_uV, &max_uV);

Reply via email to