> > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> > index 1095a6dada66..c00b0eb343c0 100644
> > --- a/tools/perf/builtin-list.c
> > +++ b/tools/perf/builtin-list.c
> > @@ -67,9 +67,11 @@ int cmd_list(int argc, const char **argv, const char
> > *prefix __maybe_unused)
> > print_symbol_events(NULL, PERF_TYPE_SOFTWARE,
> > event_symbols_sw, PERF_COUNT_SW_MAX,
> > raw_dump);
> > else if (strcmp(argv[i], "cache") == 0 ||
> > - strcmp(argv[i], "hwcache") == 0)
> > + strcmp(argv[i], "hwcache") == 0) {
>
> This is changing existing behaviour, please remove it. A separate patch
> could either make it show both hwcache events and vendor cache events,
That's what the patch does: "show both hwcache and vendor cache events"
which is a reasonable default.
I can split it into a separate patch if makes you feel better.
>
> > print_hwcache_events(NULL, raw_dump);
> > - else if (strcmp(argv[i], "pmu") == 0)
> > + print_pmu_events(argv[i], raw_dump, !desc_flag,
> > + long_desc_flag, true);
> > + } else if (strcmp(argv[i], "pmu") == 0)
> > print_pmu_events(NULL, raw_dump, !desc_flag,
> > long_desc_flag, false);
>
> What is this here?
Only adding a } but diff displays it in a weird way.
-Andi
