Em Fri, 21 Oct 2016 11:01:04 -0200 Mauro Carvalho Chehab <[email protected]> escreveu:
> Em Fri, 2 Sep 2016 20:19:54 +0800 > Tiffany Lin <[email protected]> escreveu: > > > Add v4l2 layer decoder driver for MT8173 > > > > Signed-off-by: Tiffany Lin <[email protected]> > > > +int vdec_if_init(struct mtk_vcodec_ctx *ctx, unsigned int fourcc) > > +{ > > + int ret = 0; > > + > > + switch (fourcc) { > > + case V4L2_PIX_FMT_H264: > > + case V4L2_PIX_FMT_VP8: > > + default: > > + return -EINVAL; > > + } > > Did you ever test this driver? The above code will *always* return > -EINVAL, with will cause vidioc_vdec_s_fmt() to always fail! > > I suspect that what you wanted to do, instead, is: > > switch (fourcc) { > case V4L2_PIX_FMT_H264: > case V4L2_PIX_FMT_VP8: > break; > default: > return -EINVAL; Yeah, a latter patch in this series added a break there. Thanks, Mauro
