On 10/25, Oleg Nesterov wrote: > > On 10/25, Roman Pen wrote: > > > > This patch avoids allocation of kthread structure on a stack, and simply > > uses kmalloc. > > Oh. I didn't even read this patch, but I have to admit I personally do not > like it. I can be wrong, but imo this is the step to the wrong direction.
And after I tried to actually read it I dislike it even more, sorry Roman. Starting from the fact it moves kthread_create_info into struct kthread. > struct kthread is already bloated, we should not bloat it more. Instead > we should kill it. And to_kthread() too, at least in its current form. Yes, but even if we can't or do not want to do this, even if we want to kmalloc struct kthread, I really think it should not be refcounted separately from task_struct. something like the patch in http://marc.info/?l=linux-kernel&m=146715459127804 Either way to_live_kthread() must go away. Currently we can't avoid it because we abuse vfork_done, but as I already said we no longer need this. Oleg.
