Ingo Molnar <mi...@kernel.org> writes: > * Michael Ellerman <m...@ellerman.id.au> wrote: >> @@ -564,8 +560,11 @@ void __init smp_init(void) >> cpu_up(cpu); >> } >> >> + num_nodes = num_online_nodes(); >> + pr_info("smp: Brought up %d node%s, %d CPUs\n", >> + num_nodes, (num_nodes > 1 ? "s" : ""), num_online_cpus()); > > No objections - but pedantry requires me to mention that while we are > evolving > this code and changing the strings I think we should make the CPU > announcement > CPU%s smart as well: an SMP kernel on a single CPU bootup will result in > num_online_cpus() == 1, right?
Yeah that makes sense. I don't often boot any single CPU systems, but I tested with maxcpus=1 and it does look nicer: smp: Brought up 2 nodes, 1 CPU Will send a v2. cheers