Hello Benjamin, On 26 October 2016 at 19:02, Benjamin Gaignard <[email protected]> wrote: > It is more or less a copy of Hisilicon driver but with a heap definition > fitting with STIH4xx SoC needs. > I have just chnage the some function prefix from "hi6220" to "sti". > Thanks for your patches!
I was just wondering if you couldn't convert the HiSilicon driver into something like a 'simple-ion' driver, and have just the DT definitions as specifics? This would save a lot of code duplication, and keep it as a simple interface for common heaps like cma. If there are any ST-specific requirements that are incompatible with the existing driver, it should be clearly documented out here I think. > Benjamin Gaignard (3): > add binding for STIh4xx ION driver > add STIH4xx ION driver > add STIH4xx ION driver in DT > > .../devicetree/bindings/staging/ion/st,sti-ion.txt | 14 +++ > arch/arm/boot/dts/stih407-family.dtsi | 7 ++ > drivers/staging/android/ion/Kconfig | 7 ++ > drivers/staging/android/ion/Makefile | 2 + > drivers/staging/android/ion/sti/Makefile | 1 + > drivers/staging/android/ion/sti/sti_ion.c | 103 > +++++++++++++++++++++ > 6 files changed, 134 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/staging/ion/st,sti-ion.txt > create mode 100644 drivers/staging/android/ion/sti/Makefile > create mode 100644 drivers/staging/android/ion/sti/sti_ion.c > > -- > 1.9.1 > Best regards, Sumit.
