On 10/26/2016 10:56 PM, Lee Jones wrote:
diff --git a/include/linux/mfd/tps65217.h b/include/linux/mfd/tps65217.h
> index 4ccda89..75a3a5f 100644
> --- a/include/linux/mfd/tps65217.h
> +++ b/include/linux/mfd/tps65217.h
> @@ -235,9 +235,9 @@ struct tps65217_bl_pdata {
>  };
>
>  enum tps65217_irq_type {
> -  TPS65217_IRQ_PB,
> -  TPS65217_IRQ_AC,
>    TPS65217_IRQ_USB,
> +  TPS65217_IRQ_AC,
> +  TPS65217_IRQ_PB,
>    TPS65217_NUM_IRQ
>  };
This is why using enum for these types of assignments is sometimes
dangerous.  It's probably best to be explicit.

I agree with you. Let me fix in v2 - use #define instead of enum type.

Best regards,
Milo

Reply via email to