Am Dienstag, den 01.11.2016, 08:10 +0100 schrieb Lukasz Majewski: > From: Sascha Hauer <[email protected]> > > The use of the ipg clock was introduced with commit 7b27c160c681 > ("pwm: i.MX: fix clock lookup"). > In the commit message it was claimed that the ipg clock is enabled for > register accesses. This is true for the ->config() callback, but not > for the ->set_enable() callback. Given that the ipg clock is not > consistently enabled for all register accesses we can assume that either > it is not required at all or that the current code does not work. > Remove the ipg clock code for now so that it's no longer in the way of > refactoring the driver. > > Signed-off-by: Sascha Hauer <[email protected]> > Cc: Philipp Zabel <[email protected]>
I don't remember the details, but since I had only worked with i.MX53 and i.MX6 at the time, and Sascha now verified that the i.MX53 PWM registers can in fact be accessed with the pwmX_ipg_clk bits gated, I can only assume that this patch is the result of a misinterpretation of the i.MX53 technical reference manual: Contrary to the i.MX6 TRM it does not mention the ungated peripheral access clock (ipg_clk_s) at all, but calls the gated ipg_clk "block interface clock" in Table 18-3. Acked-by: Philipp Zabel <[email protected]> regards Philipp
