From: Markus Elfring <[email protected]>
Date: Sun, 6 Nov 2016 21:54:38 +0100

Use a direct assignment for an array element which can be set over the
pointer variable "inp" instead of calling the function "memcpy" here.

Suggested-by: Hans Verkuil <[email protected]>
Signed-off-by: Markus Elfring <[email protected]>
---
 drivers/media/platform/davinci/vpfe_capture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/davinci/vpfe_capture.c 
b/drivers/media/platform/davinci/vpfe_capture.c
index 8314c39..5417f6b 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -1091,7 +1091,7 @@ static int vpfe_enum_input(struct file *file, void *priv,
                return -EINVAL;
        }
        sdinfo = &vpfe_dev->cfg->sub_devs[subdev];
-       memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input));
+       *inp = sdinfo->inputs[index];
        return 0;
 }
 
-- 
2.10.2

Reply via email to