On Fri, Nov 11, 2016 at 11:39:21AM +0100, Jan Glauber wrote: > Hi Mark, > > thanks for reviewing. One question below,
> On Thu, Nov 10, 2016 at 04:54:06PM +0000, Mark Rutland wrote: > > On Sat, Oct 29, 2016 at 01:55:29PM +0200, Jan Glauber wrote: > > > +#include <linux/cpufeature.h> > > > +#include <linux/numa.h> > > > +#include <linux/slab.h> > > > > I believe the following includes are necessary for APIs and/or data > > explicitly referenced by the driver code: [...] > Should I also add includes that are already in the included by > uncore_cavium.h? Please do. > I usually avoid includes that come through the "local" header file. Generally, when you explcitly use some macro/function/data in a file, that file should have the relevant include. If something's only used in the header (e.g. hidden in a macro or inline function), then we only need that include in the header. For example: uncore_cavium.h uses container_of(), and should include <linux/kernel.h>. Also, uncore_cavium.c also uses container_of() directly for something unrelated, and should also include <linux/kernel.h>. Thanks, Mark.