On Mon, Nov 14, 2016 at 08:20:28AM -0800, Jacob Pan wrote: > On Mon, 14 Nov 2016 16:01:19 +0100 > Peter Zijlstra <[email protected]> wrote: > > > On Wed, Nov 09, 2016 at 11:05:10AM -0800, Jacob Pan wrote: > > > +void play_idle() > > > +{ > > > + /* > > > + * Only FIFO tasks can disable the tick since they don't > > > need the forced > > > + * preemption. > > > + */ > > > + WARN_ON_ONCE(current->policy != SCHED_FIFO); > > > + WARN_ON_ONCE(current->nr_cpus_allowed != 1); > > > + WARN_ON_ONCE(!(current->flags & PF_KTHREAD)); > > > + WARN_ON_ONCE(!(current->flags & PF_NO_SETAFFINITY)); > > > + rcu_sleep_check(); > > > + > > > + preempt_disable(); > > > + current->flags |= PF_IDLE; > > > + do_idle(); > > > + current->flags &= ~PF_IDLE; > > > + > > > + preempt_fold_need_resched(); > > > + preempt_enable(); > > > +} > > > +EXPORT_SYMBOL_GPL(play_idle); > > > > Hurm.. didn't this initially also include the setup of the timer and > > take an timeout argument? > > right, the initial version has a timeout and > init_timer_on_stack(timer); > > I thought since this play_idle timer is likely to expire instead of > being canceled, so I switched to hrtimer by caller. We don't have an on > stack hrtimer, right? or Should we consider adding one?
hrtimer_init_on_stack() exists.
