Hi, Arnd Bergmann <[email protected]> writes: > Building with W=1, we get a warning about harmless empty statements: > > drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_handle_intf': > drivers/usb/dwc3/ep0.c:491:4: error: suggest braces around empty body in an > 'if' statement [-Werror=empty-body] > > gcc does not warn about {} here, so maybe use that instead. > Alternatively, the code could be removed entirely as it does > nothing. > > Signed-off-by: Arnd Bergmann <[email protected]> > --- > This has been present in the driver for a while, but the code > just moved around, so it showed up as a new warning for me. > I hope to eventually address all W=1 warnings as they tend to > find real bugs elsewhere and we may as well fix it now that the > code has changed.
Thank you, the only problem is that now checkpatch.pl warns. I'll just remove the code and turn it into a comment. Authorship kept, let me know if you're okay with me adding your S-o-b: 8<------------------------------------------------------------------------ From ea97b854e5c4437975c5d0e887488390410cfb30 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann <[email protected]> Date: Wed, 16 Nov 2016 16:37:30 +0100 Subject: [PATCH] usb: dwc3: ep0: avoid empty-body warning Building with W=1, we get a warning about harmless empty statements: drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_handle_intf': drivers/usb/dwc3/ep0.c:491:4: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] Instead of adding empty braces which would introduce checkpatch.pl warnings, we're just removing the code which doesn't do anything and making sure we return 0 so USBCV tool is happy. NYET-Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: Felipe Balbi <[email protected]> --- drivers/usb/dwc3/ep0.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index 2b22ea7263d8..4c0664640862 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -486,12 +486,13 @@ static int dwc3_ep0_handle_intf(struct dwc3 *dwc, switch (wValue) { case USB_INTRF_FUNC_SUSPEND: - if (wIndex & USB_INTRF_FUNC_SUSPEND_LP) - /* XXX enable Low power suspend */ - ; - if (wIndex & USB_INTRF_FUNC_SUSPEND_RW) - /* XXX enable remote wakeup */ - ; + /* + * REVISIT: Ideally we would enable some low power mode here, + * however it's unclear what we should be doing here. + * + * For now, we're not doing anything, just making sure we return + * 0 so USB Command Verifier tests pass without any errors. + */ break; default: ret = -EINVAL; -- 2.10.1 -- balbi
signature.asc
Description: PGP signature
