On Fri, 2016-11-18 at 11:19 +0000, Luis Oliveira wrote: > - The functions related to I2C master mode of operation were > transformed in a single driver. > - The name of the i2c-designware-core.c had to be changed to i2c- > designware-src.c to for the cmake to be able to correctly compile both > modules into one > - Common definitions were moved to i2c-designware-core.h
> drivers/i2c/busses/i2c-designware-src.c | 252 > +++++++++++++++ Perhaps i2c-designware-common.c ? > @@ -21,8 +21,6 @@ > * ------------------------------------------------------------------ > ---------- > * > */ > - > - No need to do that in this patch. > #define DW_IC_CON_MASTER 0x1 > #define DW_IC_CON_SPEED_STD 0x2 > #define DW_IC_CON_SPEED_FAST 0x4 > @@ -32,6 +30,123 @@ > #define DW_IC_CON_RESTART_EN 0x20 > #define DW_IC_CON_SLAVE_DISABLE 0x40 > > +/* > + * Registers offset > + */ > +#define DW_IC_CON 0x0 Okay, can we split this to move definitions and the rest? -- Andy Shevchenko <[email protected]> Intel Finland Oy
