On Fri, 18 Nov 2016 15:23:59 +0100
Peter Zijlstra <[email protected]> wrote:

 
> That said; there's something to be said for:
> 
>       u64 running_bw;
> 
> static void add_running_bw(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
> {
>       u64 old = dl_rq->running_bw;
> 
>       dl_rq->running_bw += dl_se->dl_bw;
>       SCHED_WARN_ON(dl_rq->running_bw < old); /* overflow */
> }
> 
> static void sub_running_bw(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
> {
>       u64 old = dl_rq->running_bw;
> 
>       dl_rq->running_bw -= dl_se->dl_bw;
>       SCHED_WARN_ON(dl_rq->running_bw > old); /* underflow */
> }
> 

Acked-by: me

-- Steve

Reply via email to