On Thu, Nov 24, 2016 at 07:58:49PM +0100, Peter Zijlstra wrote: > On Thu, Nov 24, 2016 at 10:28:22AM -0800, Andi Kleen wrote: > > On Thu, Nov 24, 2016 at 02:50:43PM +0100, Peter Zijlstra wrote: > > > On Thu, Nov 24, 2016 at 01:45:28PM +0000, Liang, Kan wrote: > > > > > I think we should make this optional/configurable like the rest of > > > > > the aux > > > > > events, like below.. > > > > > > > > > > > > > The overhead logging only happens when event is going to be disabled or > > > > the task is scheduling out. It should not be much and expensive. > > > > > > > > Peter, > > > > > > > > What do you think? > > > > Should we make it configurable? > > > > > > Is there a downside to having it optional? > > > > It would be good to always have at least one line overhead summary in the > > default output. So if someone sends you a perf report output file and it has > > suspicious overhead can investigate. > > Sure, but that's a tool thing, totally irrelevant for the kernel.
It requires enabling the overhead records by default. If there is really concern about not supporting old tool would need a disable instead of an enable option. -Andi
