Re: [PATCH 1/6] perf config: Add support for getting config key-value pairs

[Taeung Song]

Good morning!! Arnaldo :)


On 11/15/2016 12:50 AM, Arnaldo Carvalho de Melo wrote:

Em Fri, Nov 04, 2016 at 03:44:17PM +0900, Taeung Song escreveu:

Add a functionality getting specific config key-value pairs.
For the syntax examples,

    perf config [<file-option>] [section.name ...]

e.g. To query config items 'report.queue-size' and 'report.children', do

    # perf config report.queue-size report.children

So, I'm applying it, but while testing I noticed that it shows only the
options that were explicitely set:

[acme@jouet linux]$ perf config report.queue-size report.children
report.children=false
[acme@jouet linux]$

Perhaps we should, in a follow up patch, show this instead:

[acme@jouet linux]$ perf config report.queue-size report.children
report.children=false
# report.queue-size=18446744073709551615 # Default, not set in ~/.perfconfig
[acme@jouet linux]$

?

- Arnaldo

To also show default config values, first of all,
I think we should have default config arrays.

So I sent v9 PATCH mail for default config arrays!
If you review the patchset, I'd appreciate it! :)


Thanks,
Taeung