On Mon, Mar 05, 2007 at 05:46:27PM +0300, Michael Tokarev wrote: > Joerg Roedel wrote: > > +++ b/arch/x86_64/kernel/setup.c > > + static char *x86_svm_flags[] = { > > + "npt", > > + "lbrv", > > + "svmlock", > > + }; > > A nitpick: > > static const char *const x86_svm_flags[] = ... ?
Right. Its better to mark the array as const. Will wait for more comments and send an updated patch soon. Thanks, Joerg -- Joerg Roedel Operating System Research Center AMD Saxony LLC & Co. KG - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/