On 11/27/16 12:20, Moritz Fischer wrote: > No longer fall through into the error case that prints out > an error if no error (err = 0) occurred. > > Rework error handling to print error where it occured instead > of having a global catch-all at the end of the function. > > Fixes d9181b20a83(of: Add back an error message, restructured) > Signed-off-by: Moritz Fischer <[email protected]> > Reviewed-by: Frank Rowand <[email protected]> > --- > Hi Rob, Frank > > this has already Frank's Reviewed-by: tag on it, but since I changed around > the > earlier part (before tree_node gets assigned) Frank might wanna take another > look > at this.
< snip > Hi Moritz, I agree with Rob's suggested one line solution (that I initially misunderstood). The one line fix is to add "if (err)" immediately following label "err_out" in of_resolve_phandles(). As far as patch 2/2, I'm not bothered by the two instances of line over 80 chars. But if Rob wants to take patch 2/2 I have no objection. -Frank
