Em Wed, Nov 30, 2016 at 09:23:33AM -0600, Kim Phillips escreveu: > Presume neglected in commit 786c1b5 "perf annotate: Start supporting > cross arch annotation". This doesn't fix a bug since none of the > affected arches support parsing dec/inc instructions yet.
Applied, good catch, one tiny nit tho: [PATCH 1/2] perf annotate: use arch->objdump.comment_char in Please start the summary with a capital letter, i.e. make the above be: [PATCH 1/2] perf annotate: Use arch->objdump.comment_char in That is how I've worked pushing stuff to Ingo for years, so for consistency, please stick to that in your next patches, Thanks a lot! - Arnaldo > Signed-off-by: Kim Phillips <kim.phill...@arm.com> > Cc: Arnaldo Carvalho de Melo <a...@redhat.com> > --- > tools/perf/util/annotate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index 3e34ee0..191599e 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -408,7 +408,7 @@ static int dec__parse(struct arch *arch __maybe_unused, > struct ins_operands *ops > if (ops->target.raw == NULL) > return -1; > > - comment = strchr(s, '#'); > + comment = strchr(s, arch->objdump.comment_char); > if (comment == NULL) > return 0; > > -- > 2.10.2
