On Thu 2016-12-01 10:07:01, Sergey Senozhatsky wrote: > On (11/24/16 17:35), Petr Mladek wrote: > [..] > > > #ifdef CONFIG_PRINTK_NMI > > > -extern void printk_nmi_init(void); > > > -extern void printk_nmi_enter(void); > > > -extern void printk_nmi_exit(void); > > > -extern void printk_nmi_flush(void); > > > -extern void printk_nmi_flush_on_panic(void); > > > +extern void printk_safe_init(void); > > > +extern void printk_safe_nmi_enter(void); > > > +extern void printk_safe_nmi_exit(void); > > > > I would personally keep the short names pritnk_nmi_enter() and > > printk_nmi_exit(). These are the only functions that will stay > > in this CONFIG_PRINT_NMI section. The others are generic and > > will be moved to the generic section in the next patch. > > I'd probably prefer all printk_safe functions to be printk_safe > prefixed, just to show the fact that those are printk_safe > functions (IOW, indirect output to a per-CPU buffer and flush > it to logbuf later).
Fair enough. Best regards, Petr
