On Tue, Dec 06, 2016 at 08:21:51AM +0800, Baoyou Xie wrote:
> This patch adds header with values used for ZTE 2967
> SoC's power domain driver.
> 
> Signed-off-by: Baoyou Xie <[email protected]>
> ---
>  include/dt-bindings/arm/zte_pm_domains.h | 23 +++++++++++++++++++++++

Considering that we are adding power domain drivers into
drivers/soc/zte, it might be better to put the header into folder
include/dt-bindings/soc/.

>  1 file changed, 23 insertions(+)
>  create mode 100644 include/dt-bindings/arm/zte_pm_domains.h
> 
> diff --git a/include/dt-bindings/arm/zte_pm_domains.h 
> b/include/dt-bindings/arm/zte_pm_domains.h
> new file mode 100644
> index 0000000..1485e8d
> --- /dev/null
> +++ b/include/dt-bindings/arm/zte_pm_domains.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2015 Linaro Ltd.
> + *
> + * Author: Baoyou Xie <[email protected]>
> + * License terms: GNU General Public License (GPL) version 2
> + */
> +#ifndef _DT_BINDINGS_ARM_ZTE_PM_DOMAINS_H
> +#define _DT_BINDINGS_ARM_ZTE_PM_DOMAINS_H
> +
> +#define DM_ZX296718_SAPPU    0
> +#define DM_ZX296718_VDE              1  /*g1v6*/
> +#define DM_ZX296718_VCE              2  /*h1v6*/
> +#define DM_ZX296718_HDE              3  /*g2v2*/

The single line comment should be /* blabla */.  Note there is space
after and before *.

Shawn

> +#define DM_ZX296718_VIU              4
> +#define DM_ZX296718_USB20    5
> +#define DM_ZX296718_USB21    6
> +#define DM_ZX296718_USB30    7
> +#define DM_ZX296718_HSIC     8
> +#define DM_ZX296718_GMAC     9
> +#define DM_ZX296718_TS               10
> +#define DM_ZX296718_VOU              11
> +
> +#endif /* _DT_BINDINGS_ARM_ZTE_PM_DOMAINS_H */
> -- 
> 2.7.4
> 

Reply via email to