Hi, On Saturday, December 10, 2016 11:51:11 AM Krzysztof Kozlowski wrote: > The driver was checking for non-NULL address of struct's members: > - s3c_audio_pdata->type (union), > - s3c_audio_pdata->type.i2s (embedded struct). > > This is pointless as these will be always non-NULL. The 's3c_audio_pdata' > is always initialized in static memory so it will be zeroed. > Additionally the 'type' member was an union with only one member. > > It is safe to reorganize the structures to get rid of useless union and > checks for addresses to fix the coccinelle warning: > >> sound/soc/samsung/i2s.c:1270:2-4: ERROR: test of a variable/field > address > > Reported-by: kbuild test robot <[email protected]> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Bartlomiej Zolnierkiewicz <[email protected]> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
