On Mon, Dec 12, 2016 at 05:31:08PM +0200, Jarkko Sakkinen wrote: > On Mon, Dec 12, 2016 at 05:20:01PM +0200, Jarkko Sakkinen wrote: > > On Mon, Dec 12, 2016 at 02:25:32PM +0000, Winkler, Tomas wrote: > > > > > > > > In order to provide access to locality registers, this commits adds > > > > mapping of > > > > the head of the CRB registers, which are located right before the > > > > control area. > > > > > > > > Signed-off-by: Jarkko Sakkinen <[email protected]> > > > > --- > > > > drivers/char/tpm/tpm_crb.c | 89 > > > > +++++++++++++++++++++++++++++------------ > > > > ----- > > > > 1 file changed, 57 insertions(+), 32 deletions(-) > > > > > > > > diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c > > > > index > > > > 717b6b4..80b9759 100644 > > > > --- a/drivers/char/tpm/tpm_crb.c > > > > +++ b/drivers/char/tpm/tpm_crb.c > > > > @@ -52,18 +52,28 @@ enum crb_cancel { > > > > CRB_CANCEL_INVOKE = BIT(0), > > > > }; > > > > > > > > -struct crb_control_area { > > > > - u32 req; > > > > - u32 sts; > > > > - u32 cancel; > > > > - u32 start; > > > > - u32 int_enable; > > > > - u32 int_sts; > > > > - u32 cmd_size; > > > > - u32 cmd_pa_low; > > > > - u32 cmd_pa_high; > > > > - u32 rsp_size; > > > > - u64 rsp_pa; > > > > +struct crb_regs_head { > > > > + u32 loc_state; > > > > + u32 reserved1; > > > > + u32 loc_ctrl; > > > > + u32 loc_sts; > > > > + u8 reserved2[32]; > > > > + u64 intf_id; > > > > + u64 ctrl_ext; > > > > +} __packed; > > > > + > > > > > > > +struct crb_regs_tail { > > > Why to change the name this is still control_area > > And how would you name struct crb_regs_h then? > > In my opinion PC it makes a lot of sense to speak about registers here ~~ Typo.
/Jarkko
