Le 08/12/2016 à 16:31, Boris Brezillon a écrit : > On Tue, 6 Dec 2016 18:14:24 +0100 > Cyrille Pitchen <[email protected]> wrote: > >> This patch removes the WARN_ONCE() test in spi_nor_write(). >> This macro triggers the display of a warning message almost every time we >> use a UBI file-system because a write operation is performed at offset 64, >> which is in the middle of the SPI NOR memory page. This is a valid >> operation for ubifs. >> >> Hence this warning is pretty annoying and useless so we just remove it. >> >> Signed-off-by: Cyrille Pitchen <[email protected]> >> Suggested-by: Richard Weinberger <[email protected]> >> Suggested-by: Andras Szemzo <[email protected]> > > Acked-by: Boris Brezillon <[email protected]> > Applied to git://github.com/spi-nor/linux.git
>> --- >> drivers/mtd/spi-nor/spi-nor.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index c9bcd05ca5d9..cdeb2c6b1492 100644 >> --- a/drivers/mtd/spi-nor/spi-nor.c >> +++ b/drivers/mtd/spi-nor/spi-nor.c >> @@ -1265,9 +1265,6 @@ static int spi_nor_write(struct mtd_info *mtd, loff_t >> to, size_t len, >> ssize_t written; >> >> page_offset = (to + i) & (nor->page_size - 1); >> - WARN_ONCE(page_offset, >> - "Writing at offset %zu into a NOR page. Writing >> partial pages may decrease reliability and increase wear of NOR flash.", >> - page_offset); >> /* the size of data remaining on the first page */ >> page_remain = min_t(size_t, >> nor->page_size - page_offset, len - i); > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ >
