Hi Geliang, > On 28 Nov 2016, at 15:15, Geliang Tang <geliangt...@gmail.com> wrote: > > On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote: >> Hi Geliang, >> >> thanks for the simplification. Did you find those by manual inspection, or >> did you use a tool? >> >> Acked-by: Frank Haverkamp <ha...@linux.vnet.ibm.com> > > Hi Frank, > > Thanks for your review. > > I found those duplicate headers by a simple script written by myself. > I should have used scripts/checkincludes.pl to do this. Now I am using > scripts/checkincludes.pl to check GenWQE files, and I found another > duplicate header dma-mapping.h. So I updated this patch. >
Nice. Thanks for checking our code. > -Geliang > > Geliang Tang (1): > GenWQE: drop duplicate headers > > drivers/misc/genwqe/card_base.c | 1 - > drivers/misc/genwqe/card_ddcb.c | 1 - > drivers/misc/genwqe/card_utils.c | 2 -- > 3 files changed, 4 deletions(-) > > -- > 2.9.3 > I am ok with the updated version too. Acked-by: Frank Haverkamp <ha...@linux.vnet.ibm.com> Frank
