> From: Geert Uytterhoeven [mailto:[email protected]] > Sent: Wednesday, December 14, 2016 7:21 PM > To: Mark Brown <[email protected]>; Pandy Gao > <[email protected]> > Cc: [email protected]; [email protected]; Geert > Uytterhoeven <[email protected]> > Subject: [PATCH] spi: fsl-lpspi: Pre-initialize ret in > fsl_lpspi_transfer_one_msg() > > With gcc 4.1.2: > > drivers/spi/spi-fsl-lpspi.c: In function ‘fsl_lpspi_transfer_one_msg’: > drivers/spi/spi-fsl-lpspi.c:369: warning: ‘ret’ may be used uninitialized > in this function > > If the message contains no transfers, the function will set the message's > status to an uninitialized value, and will return that uninitialized value. > > While __spi_validate() should have been called in all paths leading to this, > and thus have rejected such messages, we better pre-initialize ret to be > safe for future modifications (spi_transfer_one_message() also does this). > > Signed-off-by: Geert Uytterhoeven <[email protected]> > ---
Acked-by: Gao Pan <[email protected]> Best Regards Pandy
