Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip()

[Paolo Bonzini]

On 16/12/2016 16:10, Radim Krčmář wrote:
> +     bool ret = irqchip_kernel(kvm) || irqchip_split(kvm);

        bool ret = (kvm->arch.irqchip_mode != KVM_IRQCHIP_NONE);

:)

Paolo

>  
> -     ret = (vpic != NULL);
> -     ret |= irqchip_split(kvm);
> -
> -     /* Read vpic before kvm->irq_routing.  */
> +     /* Matches with wmb after initializing kvm->irq_routing. */
>       smp_rmb();