On 22.12.2016 06:49, Moritz Fischer wrote: > From: Moritz Fischer <[email protected]> > > The Zynq Ultrascale MP uses version 1.4 of the Cadence IP core > which fixes some silicon bugs that needed software workarounds > in Version 1.0 that was used on Zynq systems. > > Signed-off-by: Moritz Fischer <[email protected]> > Cc: Michal Simek <[email protected]> > Cc: Sören Brinkmann <[email protected]> > Cc: U-Boot List <[email protected]> > Cc: Rob Herring <[email protected]> > --- > > Hi Michal, > > I think this is a slip up and should be r1p14 for > Ultrascale ZynqMP. drivers/i2c/i2c-cadence.c already uses this. > I Cc'd the u-boot list, because the same change would be required there. > > Cheers, > > Moritz > > --- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index 68a90833..a5a5f91 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -175,7 +175,7 @@ > }; > > i2c0: i2c@ff020000 { > - compatible = "cdns,i2c-r1p10"; > + compatible = "cdns,i2c-r1p14";
I was checking this internally and p10 is doing something what p14 doesn't need to do. That's why this should be compatible = "cdns,i2c-r1p14", "cdns,i2c-r1p10"; The same of course for u-boot where also p14 should be added to the driver. Thanks, Michal
